feat(test): Add npm script to test with ts-node not caching #4065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a npm script that can run - `npm run test_no_cache`, that will run the test with `TS_NODE_CACHE` set to false. Closes ReactiveX#3948
cartant
reviewed
Aug 29, 2018
There was a problem hiding this comment.
LGTM. I think it's worth having the script you've added, if only as a reminder that the cache can be the reason for passing locally and failing on Travis. I think your adding a separate script is the way to go, too, as it's massively slower than not using the cache.
| @@ -13,11 +13,12 @@ describe('Migration Schematic', () => { | |||
| tree.create('/package.json', `{}`); | |||
| }); | |||
|
|
|||
| it('adds missing dependencies', () => { | |||
| it('adds missing dependencies', (done) => { | |||
There was a problem hiding this comment.
Is the done here really needed? Is there a particular reason for adding it? It seems superfluous.
There was a problem hiding this comment.
@cartant Sorry, should have commented on that. When I added the script and ran npm run test_no_cache, the test failed with a timeout without having the done.
cartant
approved these changes
Aug 29, 2018
benlesh
approved these changes
Aug 29, 2018
|
Thanks @pertrai1 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
There is a npm script that can run -
npm run test_no_cache, that willrun the test with
TS_NODE_CACHEset to false.Related issue (if exists):
#3948